Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing mappers for AsyncWorkflowConfiguration #5904

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add missing mappers for AsyncWorkflowConfiguration #5904

merged 1 commit into from
Apr 11, 2024

Conversation

taylanisikdemir
Copy link
Contributor

What changed?
There are many places in the codebase that maps one type to another. While adding AsyncWorkflowConfiguration field to domain config a few places was missed. Updating them along with corresponding test data.

How did you test it?
unit test

@coveralls
Copy link

coveralls commented Apr 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 018ecf38-802c-4c7e-8917-4ec388ccf2da

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 93 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.04%) to 67.307%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/execution/mutable_state_util.go 2 78.13%
service/history/task/fetcher.go 2 85.57%
common/persistence/execution_manager.go 4 83.74%
service/history/task/task_util.go 4 69.43%
service/matching/taskListManager.go 4 79.7%
service/frontend/wrappers/metered/metered.go 4 66.67%
common/persistence/statsComputer.go 7 96.07%
service/history/task/transfer_standby_task_executor.go 8 87.01%
service/history/task/cross_cluster_task_processor.go 8 80.79%
Totals Coverage Status
Change from base Build 018ecf37-6c70-46a8-8890-f48c24c91b7e: -0.04%
Covered Lines: 98401
Relevant Lines: 146197
💛 - Coveralls

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

Merging #5904 (249909b) into master (5e98036) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 249909b differs from pull request most recent head e270368. Consider uploading reports for the commit e270368 to get more accurate results

Additional details and impacted files
Files Coverage Δ
common/types/mapper/proto/api.go 98.31% <100.00%> (+<0.01%) ⬆️
common/types/mapper/thrift/shared.go 97.61% <100.00%> (+<0.01%) ⬆️

... and 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8249589...e270368. Read the comment docs.

@Groxx
Copy link
Contributor

Groxx commented Apr 11, 2024

small test-surprise question, but I don't see how these changes would make anything less correct, so 👍

@taylanisikdemir taylanisikdemir force-pushed the taylan/async_wf_q_config_replication_fix branch from 5cf1920 to 249909b Compare April 11, 2024 22:04
@taylanisikdemir taylanisikdemir enabled auto-merge (squash) April 11, 2024 22:08
@taylanisikdemir taylanisikdemir force-pushed the taylan/async_wf_q_config_replication_fix branch from 249909b to e270368 Compare April 11, 2024 22:12
@taylanisikdemir taylanisikdemir merged commit 204d17f into uber:master Apr 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groxx Groxx Groxx approved these changes

@Shaddoll Shaddoll Shaddoll approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taylanisikdemir @coveralls @Groxx @Shaddoll